-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Matomo as an option for analytics_tool. #38221
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first PR. Can you add the screenshots for the change?
thank you @dirrao for the welcome! RE: screenshots, what exactly are you wanting to see? A screenshot of my debug console showing the matomo tracking code injected? |
I am referring to the UI related changes. |
Hmm, sorry for the confusion here, but there is no UI change I'm aware of with this. The html page is likely what triggered the "area:UI" tag to be added automatically. But it's just a script tag, nothing more. And this mechanism is already tested through the analytics_tool tests. Can you point out what change you're talking about that needs a screenshot? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good indeed.
Matomo is a Google Analytics alternative for use-cases that require all tracking data be kept interally.
Some static checks and docs need fixing though |
yup just saw the failures, on it! |
@potiuk - I think everything's resolved! |
ah geez, missed allow-listing "matomo" and "Matomo" for spelling! fixed! |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Matomo is a Google Analytics alternative for use-cases that require all tracking data be kept internally, and is set up the same way as the existing supported analytics tools.